demo: use pytest subtests in cuda.core system device loops to ensure full test coverage#2009
demo: use pytest subtests in cuda.core system device loops to ensure full test coverage#2009rwgk wants to merge 1 commit intoNVIDIA:mainfrom
subtests in cuda.core system device loops to ensure full test coverage#2009Conversation
Keep per-device skips and xfails from aborting the rest of the GPU system coverage. Require pytest 9 in cuda.core test environments so the built-in subtests fixture is available. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
mdboom
left a comment
There was a problem hiding this comment.
Looks like a good solution to the problem.
Do you plan to do this for all uses of get_all_devices? Ditto for the NVML tests in cuda_bindings.
Also, we should probably remove test_devices_are_the_same_architecture.
This is mainly just my way to say "hey look this is new and useful." But I'll leave this PR around in draft mode. After the dust has settled on the cuda-core v1.0.0 release, I'll look for opportunities to come back here. |
Keep per-device skips and xfails from aborting the rest of the GPU system coverage.
Require pytest >= 9.0 in cuda.core test environments so the built-in subtests fixture is available.
To see how simple this change is, it's best to review with "Hide whitespace":